OSPAP2 -- Beta test

[iago]

http://www.javaop.com/~ron/ospap2/

I've been working on this for months, in my spare time. I've finally finished up to a point where I can release it. However, I'd like to have some others look at it first, to get some opinions on it. I'd appreciate it if you could take a few minutes and try it out.

- Create an account (or use mine -- Ron / password)
- Create an album
- Upload some pictures (try multiple at once, that's a request that Trust made years ago when I did ospap1, but that I never implemented)
- Poke around different pages -- members, groups, etc.
- Play with album permissions
- Try to find a way to do SQL injection or XSS or something
- Add stuff, delete stuff, and screw around in any way you can

I'm going to reset the database, so don't worry about effing up data. Everything in there now is stuff I imported from ospap1 for testing.

If you do play with this, can you tell me:
- Where the interface can be improved
- Any errors you get (mostly from clicking links -- it's easy to generate an error by changing parameters, but normally it's just an access_denied error)
- Any way you think this can be improved, because once I release a project I hate going back to it

If you want to poke around at the sourcecode, have a look here: http://www.javaop.com/~ron/tmp/ospap2.tgz. There's no easy way to install it from that, or instructions, but it can give you a little insight into how it works (or fails to work. )

Looking forward to feedback!

[GameSnake]

I'm trying it out right now. Okay I tried to create and album (which on the next page says edit an album?!) but got this message upon completion:

Code: [Select]

exception 'Exception' with message 'MySQL Error: Unknown column 'album_simple_permissions' in 'field list': INSERT INTO `tbl_album` (`album_id`,`album_album_id`,`album_name`,`album_group_id`,`album_caption`,`album_hide_from_main_page`,`album_export_tag`,`album_max_width`,`album_max_height`,`album_mime`,`album_simple_permissions`,`album_user_id`,`album_albumpolicy_guest_id`,`album_albumpolicy_member_id`,`album_albumpolicy_group_id`) VALUES ('','','random image','0','Testing Ron's OSPAP thing!','0','','640','480','image/jpeg','1','2','40','41','42');' in /home/ron/public_html/ospap2/cls/clsDB.php:601
Stack trace:
#0 /home/ron/public_html/ospap2/cls/clsDB.php(585): clsDB::query('INSERT INTO `<<...')
#1 /home/ron/public_html/ospap2/cls/clsDB.php(666): clsDB::insertQuery('INSERT INTO `<<...')
#2 /home/ron/public_html/ospap2/pages/albums.php(402): clsDB->save()
#3 /home/ron/public_html/ospap2/cls/clsTemplate.php(71): require('/home/ron/publi...')
#4 /home/ron/public_html/ospap2/index.php(118): clsTemplate->get()
#5 {main}

[iago]

I'm trying it out right now. Okay I tried to create and album (which on the next page says edit an album?!) but got this message upon completion:

Code: [Select]

exception 'Exception' with message 'MySQL Error: Unknown column 'album_simple_permissions' in 'field list': INSERT INTO `tbl_album` (`album_id`,`album_album_id`,`album_name`,`album_group_id`,`album_caption`,`album_hide_from_main_page`,`album_export_tag`,`album_max_width`,`album_max_height`,`album_mime`,`album_simple_permissions`,`album_user_id`,`album_albumpolicy_guest_id`,`album_albumpolicy_member_id`,`album_albumpolicy_group_id`) VALUES ('','','random image','0','Testing Ron's OSPAP thing!','0','','640','480','image/jpeg','1','2','40','41','42');' in /home/ron/public_html/ospap2/cls/clsDB.php:601
Stack trace:
#0 /home/ron/public_html/ospap2/cls/clsDB.php(585): clsDB::query('INSERT INTO `<<...')
#1 /home/ron/public_html/ospap2/cls/clsDB.php(666): clsDB::insertQuery('INSERT INTO `<<...')
#2 /home/ron/public_html/ospap2/pages/albums.php(402): clsDB->save()
#3 /home/ron/public_html/ospap2/cls/clsTemplate.php(71): require('/home/ron/publi...')
#4 /home/ron/public_html/ospap2/index.php(118): clsTemplate->get()
#5 {main}

Thanks for the report! I think it's fixed, can you give 'er another go?

[Sidoh]

I didn't poke around much and maybe this is nit-picky, but some of the fonts seem really small.

[iago]

Somebody else said the same thing, and you might be right. They look fine to me, but I still use 1024x768 resolution.

I'll work on the fonts.

[chuck]

I didn't poke around much and maybe this is nit-picky, but some of the fonts seem really small.

I agree, my display at 1280x960 it looks horrible.

Warning - while you were reading a new reply has been posted. You may wish to review your post.
I hate when that happens.

[GameSnake]

After creating an album, I tried to post an image, the problem being nothing happend after I clicked the browse button.

Edit.

After creating a Group and testing the functions, when I tried to "disband" the group I got this error:



exception 'Exception' with message 'exception_accessdenied' in /home/ron/public_html/ospap2/pages/groups.php:254
Stack trace:
#0 /home/ron/public_html/ospap2/cls/clsTemplate.php(71): require()
#1 /home/ron/public_html/ospap2/index.php(118): clsTemplate->get()
#2 {main}"

Edit.

Is there some way I am missing of uploading pictures without having to create a new album?
I also find the website minimalistic and hard on the eyes. I'd suggest an update to the website layout in general.

[iago]

To other Web developers, what range of font sizes should I use?

To GS: I actually forgot to write the "disband" code, so that's expected. I'll put it on my list and do it later.

You can't upload a picture without an album, otherwise the picture has nowhere to go. Well, you can upload it, but you can't put it anywhere. I think that makes sense with the metaphor, in real life you can't share your pictures with people unless they're in an album (kinda).

In terms of design, I'm not a Web designer, and the way it looks is the best I'm going to get it. I don't think it's hard on the eyes, unless you mean the small fonts, but I'm going to change those. That being said, I don't think there's anything wrong with minimalistic for this type of site, I don't like flashy stuff and sharing pictures shouldn't be flashy anyways. If you have any specific suggestions, or if anybody wants to work with me to get a nice design, let me know.

[Blaze]

On page: http://www.javaop.com/~ron/ospap2/index.php?action=groups&subaction=view&group_id=1

Fatal error: Call to a member function get() on a non-object in /home/ron/public_html/ospap2/pages/groups.php on line 69

[GameSnake]

I'd agree a flashy web site is impractical, but the font could be bigger, and white back round hurts my eyes personally.. I just think it could look a little snazzier without doing too much to the layout.. I'm not putting your web site down I'm just trying to help by giving you suggestions and combing for a few bugs. I might help in some other way too, would it hurt if I submitted a better menu layout? It's late now but in the future I'd like to help some more.

[iago]

On page: http://www.javaop.com/~ron/ospap2/index.php?action=groups&subaction=view&group_id=1

Fatal error: Call to a member function get() on a non-object in /home/ron/public_html/ospap2/pages/groups.php on line 69

Good find, fixed.

[iago]

I'd agree a flashy web site is impractical, but the font could be bigger, and white back round hurts my eyes personally.. I just think it could look a little snazzier without doing too much to the layout.. I'm not putting your web site down I'm just trying to help by giving you suggestions and combing for a few bugs. I might help in some other way too, would it hurt if I submitted a better menu layout? It's late now but in the future I'd like to help some more.

Apparently, studies have shown that a white background is better:
http://hubel.sfasu.edu/research/AHNCUR.html

That's why I chose that.

Like I said, I'm not a designer, if you think you can make it look better feel free to send me something. I won't promise that I'll use it, though, so don't put a whole lot of work into it. I know you aren't putting it down, but I prefer getting complaints with suggestions attached.

[Sidoh]

To other Web developers, what range of font sizes should I use?

To GS: I actually forgot to write the "disband" code, so that's expected. I'll put it on my list and do it later.

You can't upload a picture without an album, otherwise the picture has nowhere to go. Well, you can upload it, but you can't put it anywhere. I think that makes sense with the metaphor, in real life you can't share your pictures with people unless they're in an album (kinda).

In terms of design, I'm not a Web designer, and the way it looks is the best I'm going to get it. I don't think it's hard on the eyes, unless you mean the small fonts, but I'm going to change those. That being said, I don't think there's anything wrong with minimalistic for this type of site, I don't like flashy stuff and sharing pictures shouldn't be flashy anyways. If you have any specific suggestions, or if anybody wants to work with me to get a nice design, let me know.

I'm no better at the layout stuff than you are, but I've read that it's good practice to use x-small, small, medium, large, etc (I had to avoid making a regular expression for that, haha) in place of explicit measurements like <x>pt or <x>px.  Depending on the font, small or medium usually works the best.  Maybe take a look at the sizes that some of the websites you like uses (SMF)?

[deadly7]

To other Web developers, what range of font sizes should I use?

I generally go with a size 14~ or so Sans Serif.. What size+face is the one you're using now?

[rabbit]

White is too hardcore.  Go with a soft blue or gray or something like that.  Also, it'd be great if you could add in Upload Directory or something so that I can upload a whole folder without having to select all 60 files individually.

[Sidoh]

White is too hardcore.  Go with a soft blue or gray or something like that.  Also, it'd be great if you could add in Upload Directory or something so that I can upload a whole folder without having to select all 60 files individually.

There's no way to do that without the use of something like flash (I'm not even sure if it's possible then).

It's pretty easy to implement support for uploading and then extracting from archive files, though.  I did that with the CMS I worked on this summer, but unfortunately, I don't think the zip module is standard with PHP and if you do it in some other way, you sort of lose out on how portable your code is.  Even still, I think that'd be a great feature for something like a photo album to have.

iago, are you planning on using AJAX anywhere?  I can already see a few places where it would be nice.

[GameSnake]

I can't "browse" a picture to upload it. And I think it's worth noting that when completing a comment, the website adds another "post comment" button on the page.

[rabbit]

White is too hardcore.  Go with a soft blue or gray or something like that.  Also, it'd be great if you could add in Upload Directory or something so that I can upload a whole folder without having to select all 60 files individually.

There's no way to do that without the use of something like flash (I'm not even sure if it's possible then).

It's pretty easy to implement support for uploading and then extracting from archive files, though.  I did that with the CMS I worked on this summer, but unfortunately, I don't think the zip module is standard with PHP and if you do it in some other way, you sort of lose out on how portable your code is.  Even still, I think that'd be a great feature for something like a photo album to have.

iago, are you planning on using AJAX anywhere?  I can already see a few places where it would be nice.

Facebook does it just fine using what appears to be AJAX+Javascript.

[iago]

I don't plan to use AJAX, it's more trouble and I don't think it would add enough benefit.

In terms of uploading a directory, I have no idea how that could be done. I didn't even know it was possible...

I can't "browse" a picture to upload it. And I think it's worth noting that when completing a comment, the website adds another "post comment" button on the page.

That's intentional, so when there are a lot of comments you can click on the top or the bottom.

[Sidoh]

Facebook does it just fine using what appears to be AJAX+Javascript.

It uses Java.  I don't know what your personal stance is on applets in pages, but I don't like them where they're not necessary.

I don't plan to use AJAX, it's more trouble and I don't think it would add enough benefit.

In terms of uploading a directory, I have no idea how that could be done. I didn't even know it was possible...

I do suppose it's a subjective thing, but I think it'd be nice to not have to wait for the page to reload if you submit a rating.  I'm sure there are other places where it'd make things run a bit more smoothly, but since it's your project, I'm not going to try to preach on what you should be doing with it.

Maybe you could look into adding archive support, then?  That'd be just about as convenient.

[iago]

I see what you mean with the rating thing, but I don't think it's such a big deal. Personally, I don't like pages that work like that, I always find it a little confusing when things don't work the way I expect them to. But yeah, totally a personal thing.

Archive support for uploading multiple files, you mean? (archive has a lot of different meanings, just making sure ) That does sound fairly simple to do, and the way pictures are uploaded it would be pretty easy to add that. I'll add it to my list.

Incidentally, I found a bug where you can click on "post comment" even if you aren't allowed to comment (getting an error message). I'll fix that later.

[Sidoh]

I see what you mean with the rating thing, but I don't think it's such a big deal. Personally, I don't like pages that work like that, I always find it a little confusing when things don't work the way I expect them to. But yeah, totally a personal thing.

It's not a big deal, but most of web design (at least it seems to me) is a collection of a bunch of silly details like that.  Also, I think it's always confusing when anything doesn't work the way you expect it to, given that you do expect it to work in some way.

Archive support for uploading multiple files, you mean? (archive has a lot of different meanings, just making sure ) That does sound fairly simple to do, and the way pictures are uploaded it would be pretty easy to add that. I'll add it to my list.

Yeah, sorry for the ambiguity.

[iago]

It's not a big deal, but most of web design (at least it seems to me) is a collection of a bunch of silly details like that.  Also, I think it's always confusing when anything doesn't work the way you expect it to, given that you do expect it to work in some way.

Haha, it's a bit of a tautology. Sorry 'bout that. What I mean is, obviously, that AJAXy stuff often doesn't feel right, it always takes me time to adjust. Plus, I tend to use the Internet with noscript enabled, so I try to make everything work without JavaScript, and things I can't should work fine without.

[Sidoh]

Haha, it's a bit of a tautology. Sorry 'bout that. What I mean is, obviously, that AJAXy stuff often doesn't feel right, it always takes me time to adjust. Plus, I tend to use the Internet with noscript enabled, so I try to make everything work without JavaScript, and things I can't should work fine without.

Hehe, I think I knew what you meant.  I was just giving you a hard time.

I understand and can sympathize with your reasons for not using AJAX, but, personally, I'm starting to expect that it's used for some of the simpler tasks like rating systems, etc.  That is, of course, just me, though.

[iago]

I fixed pretty much every problem posted here. I haven't done group disbanding or zipfile uploading, since those will take longer. I also fixed some bugs reported by Blaze, and added some features for him.

Can somebody who didn't like the fontsize before tell me if it's better now? I was using scaled fonts, apparently, so I set the base font to be a little bigger.

[Sidoh]

Yep, they're all good sizes in my opinion.

[Blaze]

I found another bug.  I think you forgot to update your database table for the new registration values.

exception 'Exception' with message 'MySQL Error: Unknown column 'user_show_empty' in 'field list': INSERT INTO `tbl_user` (`user_id`,`user_username`,`user_email`,`user_is_advanced`,`user_show_empty`,`user_remember_filter`,`user_realname`,`user_location`,`user_password`) VALUES ('','Blaze','ian@maide.ca','1','1','1','Ian','Ontario, Canada','Censored Password');' in /home/ron/public_html/ospap2/cls/clsDB.php:601
Stack trace:
#0 /home/ron/public_html/ospap2/cls/clsDB.php(585): clsDB::query('INSERT INTO `<<...')
#1 /home/ron/public_html/ospap2/cls/clsDB.php(666): clsDB::insertQuery('INSERT INTO `<<...')
#2 /home/ron/public_html/ospap2/cls/clsUser.php(69): clsDB->save()
#3 /home/ron/public_html/ospap2/pages/members.php(98): clsUser->attemptCreate()
#4 /home/ron/public_html/ospap2/cls/clsTemplate.php(71): require('/home/ron/publi...')
#5 /home/ron/public_html/ospap2/index.php(121): clsTemplate->get()
#6 {main}

[wires]

http://www.javaop.com/~ron/ospap2/index.php?action=albums

Fatal error: Call to a member function get() on a non-object in /home/ron/public_html/ospap2/pages/albums.php on line 42

[rabbit]

Add a "I forgot my password" link.  I forgot my password 

[iago]

Oh damnit, I updated my local DB but not the remote one. Oops!

I'll fix that when I get to work.

[iago]

I found another bug.  I think you forgot to update your database table for the new registration values.

exception 'Exception' with message 'MySQL Error: Unknown column 'user_show_empty' in 'field list': INSERT INTO `tbl_user` (`user_id`,`user_username`,`user_email`,`user_is_advanced`,`user_show_empty`,`user_remember_filter`,`user_realname`,`user_location`,`user_password`) VALUES ('','Blaze','ian@maide.ca','1','1','1','Ian','Ontario, Canada','Censored Password');' in /home/ron/public_html/ospap2/cls/clsDB.php:601
Stack trace:
#0 /home/ron/public_html/ospap2/cls/clsDB.php(585): clsDB::query('INSERT INTO `<<...')
#1 /home/ron/public_html/ospap2/cls/clsDB.php(666): clsDB::insertQuery('INSERT INTO `<<...')
#2 /home/ron/public_html/ospap2/cls/clsUser.php(69): clsDB->save()
#3 /home/ron/public_html/ospap2/pages/members.php(98): clsUser->attemptCreate()
#4 /home/ron/public_html/ospap2/cls/clsTemplate.php(71): require('/home/ron/publi...')
#5 /home/ron/public_html/ospap2/index.php(121): clsTemplate->get()
#6 {main}

Should be fixed. Give 'er a go.

[iago]

http://www.javaop.com/~ron/ospap2/index.php?action=albums

Fatal error: Call to a member function get() on a non-object in /home/ron/public_html/ospap2/pages/albums.php on line 42

Fixed. Thanks!

[iago]

Add a "I forgot my password" link.  I forgot my password 

Haha, nice one. I may do that tonight. For now, want me to just delete your account/reset your password?

[rabbit]

That would be great.  Make my password "password", and make my access code "access code" ()

[iago]

All right, your password should now be "password". I have no idea what you're talking about for the access code, though.

[rabbit]

It's from RvB

Also, maybe display how many pictures are in each album on the Album List page http://www.javaop.com/~ron/ospap2/index.php?action=albums

[iago]

It's from RvB

I still don't know what you're talking about, although RLB are my initials.

Also, maybe display how many pictures are in each album on the Album List page http://www.javaop.com/~ron/ospap2/index.php?action=albums

It already does, if you have JavaScript enabled and you click the little "+". If you have JavaScript disabled, then cute little features like that won't work but the site itself will.

[Sidoh]

I still don't know what you're talking about, although RLB are my initials.

Red vs. Blue.  It was some weekly (?) video enacted with characters from the first Halo game.

[iago]

I still don't know what you're talking about, although RLB are my initials.

Red vs. Blue.  It was some weekly (?) video enacted with characters from the first Halo game.

Haha ok. I have no idea what that is, and I really don't know anything about Halo (other than that I didn't like it). Ohwell.

[iago]

So I rolled out the new version, build 2. I've made a lot of suggested changes (all of them posted here, I think?), the most major ones being:

• Added the ability to automatically upgrade the database from any lower version to the current version. Doesn't really affect users, but it helps me out a lot.
• Added "Forgot password" functionality, which emails you a temporary password.
• You can now upload pictures from the main page, but you have to select the album manually (of course).
• You can now upload a .zip file, if the php version on the server supports it.

Right now, my server doesn't support .zip uploading, but that should change within the hour.

As usual, comments are appreciated! Try out the new stuff and tell me what you think.


<edit> Server has been recompiled, .zip files can now be uploaded.

[rabbit]

Add tar support if you can.

[iago]

I'm not sure whether or not PHP supports that. Anybody know?

[Sidoh]

I'm not sure whether or not PHP supports that. Anybody know?

I'm not sure, but isn't the format of a tar file pretty straightforward?

[rabbit]

SMF's webinstall.php file seems to be able to decompress and open tar(.gz) files just fine, and I remember doing something with tars.

[iago]

So from what I can find, there is gzip and rar compression built into PHP, but not tar. Although tar is simple enough, the only library I could find is standard GPL, which is no good to me.

I could use commandline tools, but that sounds like trouble/exploits waiting to happen.

I don't think it's a big enough deal, really. Most Linux systems come with a zip utility (infozip, I think?). Of course, if there's a way to convert a tgz to a zip on the fly, then I could just do that on the server end into a temp file, if the right programs are available.

[Krazed]

I couldn't upload .bmp, was forced to switch to jpeg. 

[iago]

Hmm, I hadn't ever considered using .bmp. Heh. Maybe I'll add that in 2.1, I have a few fixes I need to make when I have time.

[Krazed]

Shrug, I was just bored so I made a little ospap2 signature image, saved it as bmp, and couldn't upload it.

[iago]

Haha nice, you should make it a link.

Paint can save as .PNG files, they're better than .BMP in every way I can think it.

[Krazed]

Haha nice, you should make it a link.

Paint can save as .PNG files, they're better than .BMP in every way I can think it.

True, I was half-listening to the lecture I was in, so I wasn't really thinking about it.