Author Topic: [JAVA] Easy-To-Use Socket Interface  (Read 9094 times)

0 Members and 1 Guest are viewing this topic.

Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #15 on: November 25, 2005, 04:52:52 pm »
If you tell the socket to write "test", it will send "test", nothing more, nothing less.

I'm not really sure how buffered input streams (or whatever I'm using =p) work, but I guess each time it recieves a TCP packet, it adds that packet as a new thing on the buffer, and when you ask for something from the buffer, it returns the first thing and then bumps everything up a notch.
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #16 on: January 30, 2007, 12:46:21 am »
Sorry to bump this, but I found some new use to it. After going through a semester of Java programming, I've decided to fix the way I did some formatting and whatnot, and I made it more generic (it doesn't use my console class, but rather uses System.err for what's necessary).

EDIT -
Whoops -- didn't review it carefully enough. I just remembered that I learned what staticness was in class, and when I wrote this, I was just trying to get around it. Fixed.

Code: [Select]
package networking;

/*
 * Author: Joe[x86]
 *
 * This is just a socket wrapper I made to make sockets easier to use
 * Methods:
 * - bool connect(String, int)
 * - bool isConnected()
 * - void sendData(String)
 * - void sendData(byte[])
 * - bool hasData()
 * - String getData()
 */

import java.net.*;
import java.io.*;

public class SocketWrapper
{
    private Socket sck;
    private BufferedReader sck_BR;
    private OutputStream sck_OS;
   
    public SocketWrapper()
    {
    }
   
    public SocketWrapper(Socket socket)
    {
    this.sck = socket;
    makeStreams();
    }
   
    public boolean isConnected()
    {
    return sck.isConnected();
    }
   
    public String getData() {
    try
    {
    return sck_BR.readLine();
    }
    catch(IOException e)
    {
    System.err.println("Socket threw IOException in getData():\n" + e.toString());
    return "";
    }
    }

    public boolean hasData()
    {
    try
    {
    if(sck_BR.ready() == true)
    {
    return true;
    }
    else
    {
    return false;
    }
    }
    catch(IOException e)
    {
    System.err.println("Socket threw IOException in hasData():\n" + e.toString());
    return false;
    }
   
    }
   
    public boolean connect(String hostname, int port)
    {
        try {
        sck = new Socket(hostname, port);
        }
        catch(IOException e)
        {
        System.err.println("Socket threw IOException in connect():\n" + e.toString());
    return false;
        }
        return makeStreams(); // this will return true if makeStreams() works
    }

public void sendData(String data)
{
try
{
for(int i = 0; i < data.length(); i++)
{
sck_OS.write(data.charAt(i));
}
sck_OS.flush();
}
catch(IOException e)
{
System.err.println("Socket threw IOException in sendData():\n" + e.toString());
}
}

public void sendData(byte[] data)
{
try
{
sck_OS.write(data);
sck_OS.flush();
}
catch(IOException e)
{
System.err.println("Socket threw IOException in sendData():\n" + e.toString());
   
}
}

private boolean makeStreams()
{
try
{
sck_OS = sck.getOutputStream();
sck_BR = new BufferedReader(new InputStreamReader(sck.getInputStream()));
}
catch(IOException e)
{
System.err.println("Socket threw IOException in makeStreams():\n" + e.toString());
try
{
sck.close();
}
catch(IOException ex)
{
// who cares? If we had an exception, it's closed anyhow. :)
}
return false;
}
return true;
}
}
« Last Edit: January 30, 2007, 01:10:11 am by Joe[x86] »
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline AntiVirus

  • Legendary
  • x86
  • Hero Member
  • *****
  • Posts: 2521
  • Best
    • View Profile
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #17 on: January 31, 2007, 11:16:41 am »
Code: [Select]
   
public SocketWrapper()
{
}

What is the point of that?
The once grove of splendor,
Aforetime crowned by lilac and lily,
Lay now forevermore slender;
And all winds that liven
Silhouette a lone existence;
A leafless oak grasping at eternity.


"They say that I must learn to kill before I can feel safe, but I rather kill myself then turn into their slave."
- The Rasmus

Offline Sidoh

  • x86
  • Hero Member
  • *****
  • Posts: 17634
  • MHNATY ~~~~~
    • View Profile
    • sidoh
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #18 on: January 31, 2007, 11:41:32 am »
What is the point of that?

It's an override of the constructor so you don't have to provide parameters to create a 'SocketWrapper' object.  I'm not sure it makes sense considering the other constructor calls private methods, though...

Offline MyndFyre

  • Boticulator Extraordinaire
  • x86
  • Hero Member
  • *****
  • Posts: 4540
  • The wait is over.
    • View Profile
    • JinxBot :: the evolution in boticulation
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #19 on: January 31, 2007, 11:43:39 am »
Code: [Select]
   
public SocketWrapper()
{
}

What is the point of that?

The connect(String, int) method creates a new Socket object.  Creating a SocketWrapper instance with a Socket parameter does not require connect to be called; creating one without a parameter requires connect to be called.

If that constructor wasn't there, he couldn't create a SocketWrapper without a socket parameter.

I'm not sure it makes sense considering the other constructor calls private methods, though...
The connect method calls the private method you're referring to.
I have a programming folder, and I have nothing of value there

Running with Code has a new home!

Our species really annoys me.

Offline Sidoh

  • x86
  • Hero Member
  • *****
  • Posts: 17634
  • MHNATY ~~~~~
    • View Profile
    • sidoh
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #20 on: January 31, 2007, 01:33:03 pm »
The connect method calls the private method you're referring to.

Missed that.  Unfortunately, I don't have the patience to sift through Joe's code. :(

Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #21 on: January 31, 2007, 10:56:31 pm »
The connect method calls the private method you're referring to.

Missed that.  Unfortunately, I don't have the patience to sift through Joe's code. :(

I'm not sure if you were trying to insult my code or your patience by saying that, but if you ask me, my code is just about as readable as JavaOp2, which is pretty decent.

And yeah, MyndFyre is correct.. originally I didn't have any constructor at all, but now that I allowed it to be constructed with a Socket object passed, I needed to manually put a no-args constructor in there. When you don't have any constructor at all, Java automagically gives it a no-args constructor.
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Sidoh

  • x86
  • Hero Member
  • *****
  • Posts: 17634
  • MHNATY ~~~~~
    • View Profile
    • sidoh
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #22 on: January 31, 2007, 11:11:14 pm »
I'm not sure if you were trying to insult my code or your patience by saying that, but if you ask me, my code is just about as readable as JavaOp2, which is pretty decent.

It'd be obvious if I was trying to insult your code.  I'm not trying to insult it; I'm merely saying I don't have the patience to read it.

Offline warz

  • Hero Member
  • *****
  • Posts: 1134
    • View Profile
    • chyea.org
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #23 on: January 31, 2007, 11:59:21 pm »
If I were wanting to read it, i'd probably drop it also. Nothing looks worse to me than code designating an entire line to a single opening french bracket ({).
« Last Edit: February 01, 2007, 12:00:53 am by warz »
http://www.chyea.org/ - web based markup debugger

Offline Sidoh

  • x86
  • Hero Member
  • *****
  • Posts: 17634
  • MHNATY ~~~~~
    • View Profile
    • sidoh
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #24 on: February 01, 2007, 12:42:18 am »
If I were wanting to read it, i'd probably drop it also. Nothing looks worse to me than code designating an entire line to a single opening french bracket ({).

I prefer adding curly brackets (I prefer that name for them :P) after statements as well.  Since it's a completely subjective decision, though, I don't think it really matters which way you prefer...

Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #25 on: February 01, 2007, 05:26:55 pm »
I have an ungodly huge resolution, and I don't like code that looks clumped together. The brainchild of these two factors is the braces getting their line.

And what's the real name for them? To me, ( ) has always been parenthesis, [ ] are brackets, and { } are braces.
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Sidoh

  • x86
  • Hero Member
  • *****
  • Posts: 17634
  • MHNATY ~~~~~
    • View Profile
    • sidoh
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #26 on: February 01, 2007, 08:21:25 pm »
I have an ungodly huge resolution, and I don't like code that looks clumped together. The brainchild of these two factors is the braces getting their line.

And what's the real name for them? To me, ( ) has always been parenthesis, [ ] are brackets, and { } are braces.

Every CS professor here refers to them as "curly brackets."  I've never heard them called "French Brackets."

Offline MyndFyre

  • Boticulator Extraordinaire
  • x86
  • Hero Member
  • *****
  • Posts: 4540
  • The wait is over.
    • View Profile
    • JinxBot :: the evolution in boticulation
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #27 on: February 01, 2007, 09:18:15 pm »
I have an ungodly huge resolution, and I don't like code that looks clumped together. The brainchild of these two factors is the braces getting their line.

And what's the real name for them? To me, ( ) has always been parenthesis, [ ] are brackets, and { } are braces.
Those are the names I've used, except () are parentheses, and one is a parenthesis.
I have a programming folder, and I have nothing of value there

Running with Code has a new home!

Our species really annoys me.

Offline rabbit

  • x86
  • Hero Member
  • *****
  • Posts: 8092
  • I speak for the entire clan (except Joe)
    • View Profile
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #28 on: February 02, 2007, 12:21:54 pm »
I have an ungodly huge resolution, and I don't like code that looks clumped together. The brainchild of these two factors is the braces getting their line.

And what's the real name for them? To me, ( ) has always been parenthesis, [ ] are brackets, and { } are braces.

Every CS professor here refers to them as "curly brackets."  I've never heard them called "French Brackets."
Ditto!

Offline iago

  • Leader
  • Administrator
  • Hero Member
  • *****
  • Posts: 17914
  • Fnord.
    • View Profile
    • SkullSecurity
Re: [JAVA] Easy-To-Use Socket Interface
« Reply #29 on: February 03, 2007, 12:43:55 pm »
Yeah, they're generally called curly brackets or braces here, usually braces. 

And I greatly prefer putting the opening brace on its own line.  I find it makes it easier to match up braces.  Also, it keeps code more spaced out which makes it look cleaner.  From marking assignments, I can tell you that I, as a marker, greatly prefer it on the next line. 

One of my profs was telling me that the on-the-same-line convention was created because of text-books, which have limited space.  In the olden days (think Pascal), it had to be on the next line. 

But you're right, it's completely subjective.  Those are just my opinions.  Of course, anybody who doesn't agree with me is very much wrong (kidding, of course :P)