CVS modifications..

[Joe]

Someone is making modifications to the CVS (notably clan features) and not noting them in javaop2/CHANGELOG.txt.

IF YOU MAKE A CHANGE, MAKE A NOTE OF IT, IF NOT IN THE CHANGELOG, ON THE FORUMS!

Thank you.

[Hdx]

Please note changes in the PLUGIN\ChangeLog.txt
This is one thing I will fight you forever on joe, JavaOp is modulirized. The CORE should stay the core, everything should be build off of Plugins as it is.
So there should not be 'JavaOp v###' when you update the BNetLogin, only when you update the Core.
~Hdx

[Joe]

Apparently you didn't commit your changelog, otherwise I wouldn't have been so pissed.

Or maybe I just missed it.

Either way, I moved your packet constants into javaop_pub.Constants.PacketConstants, where the rest of them are. Accordingly, I renamed 0x78 and 0x7A to their proper names in that list (previously UNKNOWN_78 and UNKNOWN_7A).

EDIT -
War3Clan
- bin
- - ClanConstants.class
- - PluginMain.class
- - PluginMain$Invite.class
- src
- - ClanConstants.java
- - PluginMain.java
- .classpath
- .project
- manifest.mf
- War3Clan.jardesc

No changelog on the CVS.

Also, please sign your commit comments.

[Hdx]

I haven't upload my new War3 plugin 0.o
maybe someone else did.
Last thing I uploaded was the eintire database. <3 recursive batch scripts.
~Hdx

[chuck]

Since both of you are almost always comiting changes, you should have your own CVS accounts. cvsuser should be for the casual developer, not the main developers!

[Hdx]

We do have our own accounts.

Code: [Select]

  -Advertisements
    -Removed debug code.
    -Added 'Download ads', automatically download the add files from Bnet's FTP server if you do not have it locally.
  -Clan
    -Changed to 'WhisperOnLeave', Why the hell was it named Clan?
*committing the changes soon*
I'm going through the plugins making mods and cleaning it up.

~Hdx

[chuck]

We do have our own accounts.

Oh, ok.

By the way, what ever happened to www.javaop.com? It looks like it has not been updated in awhile.

[Joe]

iago owns that.. I could probably get a hold of access to it, but I don't feel like it.