C#: Throwing warnings?

[Joe]

In C#, is there any way to throw a warning, like the ones the compiler gives you? Sort of like an exception, only not a fatal error, and the function can continue? For example, in my my connection sanity, I'd like to do something like this:

Code Select Expand

            // Check for an illegal client.
            if (!( m_sClient.Equals("RATS") || m_sClient.Equals("PXES") || m_sClient.Equals("NB2W") || m_sClient.Equals("VD2D") ||
                   m_sClient.Equals("PX2D") || m_sClient.Equals("3RAW") || m_sClient.Equals("PX3W")))
                throw new ArgumentOutOfRangeException(null, "You have not selected a valid client. See the readme for more information.");

            // LOOK AT ME
            if (m_sClient.Equals("RATS") || m_sClient.Equals("PXES"))
                throw new ConnectionWarning("StarCraft and Brood War are currently subject to checks by Blizzard's Wardent technology, "
                    + "causing possible disconnections after a few minutes.");
            // LOOK AT ME

            // Check if they're attempting to use an SPR-related client (unsupported).
            if (m_sClient.Equals("3RAW") || m_sClient.Equals("PX3W"))
                throw new ArgumentOutOfRangeException(null, "The product you have selected has not had it's logon method implemented.");

(See the LOOK AT ME part in the middle)

Does anyone know of a way to do this?

[MyndFyre]

I think you really need to take a look at your design.  Should something so deep as your connection, which has several layers of abstraction, be communicating with your user interface in such a high level?  Probably not.

Exceptions are supposed to be raised in exceptional circumstances.  Clearly this isn't such a case.

An alternative might be to create a "Warning" event:

Code Select Expand


// outside of classes
public delegate void WarningEventHandler(object sender, WarningEventArgs e);
public class WarningEventArgs : EventArgs
{
    private string m_msg;

    public WarningEventArgs(string warning)
    {
        m_msg = warning;
    }

    public string Message { get { return m_msg; } }
}

// in the class
[field: NonSerialized]
public event WarningEventHandler Warning;
protected virtual void OnWarning(WarningEventArgs e)
{
    if (Warning != null)
        Warning(this, e);
}

// in your method
if (string.Compare(m_sClient, "RATS", true) == 0 || string.Compare(m_sClient, "PXES", true) == 0)
    OnWarning(new WarningEventArgs("Starcraft and Brood War..."));


[Newby]

x86] link=topic=10676.msg136245#msg136245 date=1195498394]

Code Select Expand

            // Check for an illegal client.
            if (!( m_sClient.Equals("RATS") || m_sClient.Equals("PXES") || m_sClient.Equals("NB2W") || m_sClient.Equals("VD2D") ||
                   m_sClient.Equals("PX2D") || m_sClient.Equals("3RAW") || m_sClient.Equals("PX3W")))
                throw new ArgumentOutOfRangeException(null, "You have not selected a valid client. See the readme for more information.");

...

            // Check if they're attempting to use an SPR-related client (unsupported).
            if (m_sClient.Equals("3RAW") || m_sClient.Equals("PX3W"))
                throw new ArgumentOutOfRangeException(null, "The product you have selected has not had it's logon method implemented.");

Why is it that at first you call 3RAW and PX3W invalid... and then proceed to mention that you can't login with them? Wouldn't it make sense that since they don't exist, their login method doesn't exist either?

You should probably stop having all that sex, it's making you retarded.

A good program should simply pick the reversed 4-letter names for the products and... reverse them back on its own. Don't rely on telling the user to pick a 'real' product because as far as they're concerned, RATS could very well be what they used in another program, so they'll just go back to it.

[Joe]

Why is it that at first you call 3RAW and PX3W invalid... and then proceed to mention that you can't login with them? Wouldn't it make sense that since they don't exist, their login method doesn't exist either?

You should probably stop having all that sex, it's making you retarded.

You should get laid. You missed the not operation.

A good program should simply pick the reversed 4-letter names for the products and... reverse them back on its own. Don't rely on telling the user to pick a 'real' product because as far as they're concerned, RATS could very well be what they used in another program, so they'll just go back to it.

I'm really touched that you approve of my coding.

[Warrior]

x86] link=topic=10676.msg136301#msg136301 date=1195541994]

Why is it that at first you call 3RAW and PX3W invalid... and then proceed to mention that you can't login with them? Wouldn't it make sense that since they don't exist, their login method doesn't exist either?

You should probably stop having all that sex, it's making you retarded.

You should get laid. You missed the not operation.

A good program should simply pick the reversed 4-letter names for the products and... reverse them back on its own. Don't rely on telling the user to pick a 'real' product because as far as they're concerned, RATS could very well be what they used in another program, so they'll just go back to it.

I'm really touched that you approve of my coding.

You should be touched, because I don't approve of it.

Horrible. F

[MyndFyre]

x86] link=topic=10676.msg136305#msg136305 date=1195570177]
You should be touched, because I don't approve of it.

You're saying you touch Joe?  Homo pedophile.

x86] link=topic=10676.msg136305#msg136305 date=1195570177]
Horrible. F

K maddox.

[Warrior]

x86/64] link=topic=10676.msg136313#msg136313 date=1195586693]

x86] link=topic=10676.msg136305#msg136305 date=1195570177]
You should be touched, because I don't approve of it.

You're saying you touch Joe?  Homo pedophile.

x86] link=topic=10676.msg136305#msg136305 date=1195570177]
Horrible. F

K maddox.

party poopers poop at parties.

[Camel]

I prefer to read and write the product id as a DWORD, so I can switch() on it.

[MyndFyre]

I prefer to read and write the product id as a DWORD, so I can switch() on it.

Good thing that C# can switch on strings. :)

[Joe]

x86/64] link=topic=10676.msg136343#msg136343 date=1195616254]

I prefer to read and write the product id as a DWORD, so I can switch() on it.

Good thing that C# can switch on strings. :)

Oh. Hehe. Thanks for telling me that a few months ago. :P

[Camel]

The purpose of a switch statement is to avoid giving bias to the options at the top of the if..else if.. tree. Allowing a switch statement to accept anything beyond constant integer base types for its cases is just silly.

[Newby]

x86] link=topic=10676.msg136301#msg136301 date=1195541994]
You should get laid. You missed the not operation.

So if they enter "STAR" or "SEXP" it'll say invalid product? That's just as retarded. :|

[iago]

The purpose of a switch statement is to avoid giving bias to the options at the top of the if..else if.. tree. Allowing a switch statement to accept anything beyond constant integer base types for its cases is just silly.

Huh? That doesn't make any sense! An if/else tree with non-overlapping cases gives no bias, so that reason makes no sense.

The reason you use a switch/case is purely speed and style.

[Joe]

x86] link=topic=10676.msg136301#msg136301 date=1195541994]
You should get laid. You missed the not operation.

So if they enter "STAR" or "SEXP" it'll say invalid product? That's just as retarded. :|

See the link. They click StarCraft or StarCraft Expansion in the config dialog. You may notice that I switched the direction of all the product codes after posting this.

[Camel]

The purpose of a switch statement is to avoid giving bias to the options at the top of the if..else if.. tree. Allowing a switch statement to accept anything beyond constant integer base types for its cases is just silly.

Huh? That doesn't make any sense! An if/else tree with non-overlapping cases gives no bias, so that reason makes no sense.

The reason you use a switch/case is purely speed and style.

No, an if/else tree evaluates the conditions in the order they appear. A switch table with constant base types as its cases uses a jump table, which more appropriate for this case.

In any event, for this particular example, where this code is executed once per execution, it is hardly worth arguing over. As a matter of principle, however, you should at least be aware of how each one works.