News:

Pretty crazy that we're closer to 2030, than we are 2005. Where did the time go!

Main Menu

Split from: Changes / bugfixes requested for beta43.

Started by iago, April 23, 2008, 06:26:48 PM

Previous topic - Next topic

0 Members and 2 Guests are viewing this topic.

iago

I can give you an updated version of bnetlogin that supports Warden to a point (can display information about + download Warden modules). It could probably be modified to send back proper responses as well, although I'd put it off by default because it risks a ban.

Hdx

Wouldn't it be better to move Warden stuff to Warden.jar?
I was in the middle of doing that before I got bored and wondered off.
http://img140.exs.cx/img140/6720/hdxnew6lb.gif
09/08/05 - Clan SBs @ USEast
[19:59:04.000] <DeadHelp> We don't like customers.
[19:59:05.922] <DeadHelp> They're assholes
[19:59:08.094] <DeadHelp> And they're never right.

iago

I'd say no, because it requires information from the login. It's possible to get that info from another plugin, but it's a little messy.

Hdx

I havn't actually looked at all the data that is exposed to plugins.
Are Client/Server tokens and CDKey exposed?
Thats all you need.
http://img140.exs.cx/img140/6720/hdxnew6lb.gif
09/08/05 - Clan SBs @ USEast
[19:59:04.000] <DeadHelp> We don't like customers.
[19:59:05.922] <DeadHelp> They're assholes
[19:59:08.094] <DeadHelp> And they're never right.

iago

Nope, those are all private data.

They can be shared, in a roundabout way, but like I said, that'd be messy.

Joe

Or, I could go ahead and expose them. I agree with Hdx. Warden.jar should handle SID_WARDEN as Warden isn't part of the logon protocol per-se.

But what it comes down to is that it's your bot. It's up to you.

EDIT -
It'd be simple to enable/disable Warden answering if it were separate, as Warden.jar could just be disabled.
Quote from: Camel on June 09, 2009, 04:12:23 PMI'd personally do as Joe suggests

Quote from: AntiVirus on October 19, 2010, 02:36:52 PM
You might be right about that, Joe.


iago

In my opinion, most of the Warden stuff should always run, the only thing that shouldn't is responding to 0x02.

Put it wherever you want, but it's already included in the login plugin. I also put all the lockdown code into the login plugin.

Joe

If you could send me your Warden code via email, that'd be appreciated. :)
Quote from: Camel on June 09, 2009, 04:12:23 PMI'd personally do as Joe suggests

Quote from: AntiVirus on October 19, 2010, 02:36:52 PM
You might be right about that, Joe.


iago

Sure, email me your address and I'll send it right out.

(That's not supposed to sound sarcastic :P)

Joe

Sure, email me your address and I'll email you mine.

Actually, I just emailed your skullsecurity one that's in your profile.
Quote from: Camel on June 09, 2009, 04:12:23 PMI'd personally do as Joe suggests

Quote from: AntiVirus on October 19, 2010, 02:36:52 PM
You might be right about that, Joe.


Camel

My solution to turning 0x02 on/off is to not send it if Starcraft.exe doesn't exist in the program folder :)

That way, users have to read the disclaimer to figure out how to turn it on.

<Camel> i said what what
<Blaze> in the butt
<Camel> you want to do it in my butt?
<Blaze> in my butt
<Camel> let's do it in the butt
<Blaze> Okay!

BoBbY)eD(


Joe

As soon as I find a sober weekend to program on.

And a JDK 1.4 package for Ubuntu. Hint hint, guys. :)
Quote from: Camel on June 09, 2009, 04:12:23 PMI'd personally do as Joe suggests

Quote from: AntiVirus on October 19, 2010, 02:36:52 PM
You might be right about that, Joe.


trust

Quote from: Joe on May 20, 2008, 02:39:28 AM
As soon as I find a sober weekend to program on.

Yeah those Smirnoff Ice's are really fucking you up, huh?

Joe

No, but three shots of everclear isn't exactly what I'd call light.
Quote from: Camel on June 09, 2009, 04:12:23 PMI'd personally do as Joe suggests

Quote from: AntiVirus on October 19, 2010, 02:36:52 PM
You might be right about that, Joe.