Author Topic: CD-Key Exception  (Read 13181 times)

0 Members and 1 Guest are viewing this topic.

Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
CD-Key Exception
« on: February 03, 2010, 10:38:09 pm »
Just updated to 2.1.2 (with the new BNetLogin.jar), tried to connect (W3XP) and got the following error:

Code: [Select]
CRITICAL: [BNET] Caught exception while validating CD-Keys: exceptions.LoginException: CDKey is not 24 characters!

Thanks for the help :)
« Last Edit: February 19, 2010, 09:28:51 pm by Lance »
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline Blaze

  • x86
  • Hero Member
  • *****
  • Posts: 7136
  • Canadian
    • View Profile
    • Maide
Re: CD-Key Exception
« Reply #1 on: February 03, 2010, 10:44:53 pm »
Is your cdkey 24 characters?  :)
And like a fool I believed myself, and thought I was somebody else...

Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #2 on: February 09, 2010, 02:37:16 am »
No; both the WAR3 and W3XP keys are 26 characters.  :)
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #3 on: February 09, 2010, 02:47:42 am »
I am looking inside BNetLogin.jar and I see Alpha24Decode.class. I guess this plugin wont work!  :D
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #4 on: February 09, 2010, 06:28:50 pm »
I got lazy and downloaded the latest javaop2 and bnetlogin projects and undid the renaming then exported the bnetlogin jar. I am not getting the 24-character key error anymore ;D but I am getting this:

Code: [Select]
... JUNK ...

[18:18:36.482] INFO: [BNET] Calculated. Sending version check..
[18:18:36.580] Login Exception:
[18:18:36.593] exceptions.LoginException: [BNET] Wrong product value for your CD Key
[18:18:36.595] packets.SidAuthCheck.checkIncoming(SidAuthCheck.java:153)
[18:18:36.595] PluginMain.processedPacket(PluginMain.java:268)
[18:18:36.610] pluginmanagers.PluginRegistration.processedIncomingPacket(PluginRegistration.java:698)
[18:18:36.617] bot.PacketThread.run(PacketThread.java:173)
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: CD-Key Exception
« Reply #5 on: February 09, 2010, 09:02:12 pm »
Did you download the updated BNetLogin jar?
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #6 on: February 09, 2010, 09:27:44 pm »
Yes
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #7 on: February 10, 2010, 01:02:25 pm »
By the way, why are the "server", "port", and "connect automatically" settings not in the BNetLogin plugin? Without the BNetLogin plugin, they are useless. :)
« Last Edit: February 19, 2010, 09:29:01 pm by Lance »
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline jays

  • Newbie
  • *
  • Posts: 2
    • View Profile
Re: CD-Key Exception
« Reply #8 on: February 14, 2010, 04:30:30 am »
I'm still getting this error, how do you fix it?

Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #9 on: February 14, 2010, 10:57:45 am »
We are waiting on our maintainer for the fix :)

I was feeling lucky so I imported the javaop2, bnetlogin, channel list, and swing gui packages from the svn and exported them. From there, I imported the CommandLineConfiguration jar from 2.1.2 and refactored some of the util class names (to comply with the new class names in 2.1.3), and jar'ed that too. Next, I ran the cmdlineconfigure jar, set up a bot with only the three previously mentioned plugins, saved my bnetlogin settings, reloaded the bot, and tried to connect. The bot is still a little rough around the edges because it is in development, but the problem from the old BnetLogin plugin persists... Take a look:



Nothing funny with the stack trace except for this:
Code: [Select]
Exception in Metacity for theme "Nodoka": Variable "mini_icon_width" not defined
But I am positive it has nothing to do with the BnetLogin problem.
« Last Edit: February 19, 2010, 09:29:19 pm by Lance »
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: CD-Key Exception
« Reply #10 on: February 15, 2010, 12:08:55 am »
I'm proud of you. Nobody else follows SVN as far as I know. :)

The issue, I believe, is something to do with the fact that KEYLEN was marked final. You can thank Ron for that. Well, he didn't make the ruhtard move of making it 24, but eh?

Anyhow, I'm so far past 2.1.2 that unless anyone wants to be a saint and recompile the entire bot for me, this will wait until 2.1.3, but since like 50 of you have complained (I didn't know that many of you used JavaOp still!), I'll make that my #1 priority project, which admittedly doesn't mean much.

If it's not out by this Saturday, please annoy me. Especially via IM. :)
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: CD-Key Exception
« Reply #11 on: February 15, 2010, 02:26:56 am »
Try the SVN now. If that doesn't work, I'm working on a full reversal of StarCraft's 26-char key methods. In fact, even if it does, I'm going to use the new code because I like it better.

Make sure you recompile the entire bot. Just go to your svn folder and type 'ant'.
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #12 on: February 15, 2010, 12:39:00 pm »
That resolves the key length issue :) but not the product value one :'(

Thanks :)
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: CD-Key Exception
« Reply #13 on: February 15, 2010, 06:53:59 pm »
Well cool, that's like the deck integrity on an aircraft carrier being enough so a plane can land, but it still can't float!

I'm working on reversing StarCraft's decoder as we speak.
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #14 on: February 15, 2010, 06:58:12 pm »
Is the b43 BnetLogin plugin archived somewhere? iago had a link up for b43 but it's dead now :(
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: CD-Key Exception
« Reply #15 on: February 16, 2010, 08:04:35 pm »
Fixed. SVN upload in the next few minutes, after I nab a byte [sic] to eat.

Hopefully 2.1.3 will be out by the end of the week. If I remember (and I won't), I'll recompile 2.1.2 when I get home to hopefully get a working bot in everyone's hands.
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #16 on: February 16, 2010, 09:18:05 pm »
Flushed Alpha.jbb just to make sure it was not the settings (just got the default <CDKEY HERE> error), then I entered the new settings and saved them, but I still got this:



This is resolved by changing lines 24 and 25 in packets.SidAccountLogon which are:
Code: [Select]
String username = pubFuncs.getLocalSetting("Battle.net Logon Plugin", "username");
String password = pubFuncs.getLocalSetting("Battle.net Logon Plugin", "password").toLowerCase();
To:
Code: [Select]
String username = pubFuncs.getLocalSetting("Battle.net Login Plugin", "username");
String password = pubFuncs.getLocalSetting("Battle.net Login Plugin", "password").toLowerCase();

But it seems to have exposed another problem:


Thanks :)
« Last Edit: February 19, 2010, 09:29:34 pm by Lance »
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: CD-Key Exception
« Reply #17 on: February 17, 2010, 01:04:34 am »
Wow, my recent changes are turning out to be some kind of a joke. I'll get right on those. Thank you very much for testing this out with me.

Feel free to add me on AIM or MSN, by the way. joetheodd or joetheodd@gmail.com
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: CD-Key Exception
« Reply #18 on: February 17, 2010, 02:57:24 am »
Okay -- I cleaned up a ton and a half of SRP code. I'm now getting a incorrect password password after SID_AUTH_ACCOUNTLOGON proof. It's in subversion if you want to track it down, or if not I'll solve it tomorrow morning when I'm tutoringgetting paid to do nothing.

The important news is both WarCraft III and StarCraft pass SID_AUTH_CHECK with 26-character keys. Also, off-topic but Hdx fixed StealthBot as well.
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #19 on: February 17, 2010, 09:05:41 am »
It works! Just had to remove that extra cdkey folder in the root directory :)

Thanks Joe!
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!

Offline Joe

  • B&
  • Moderator
  • Hero Member
  • *****
  • Posts: 10319
  • In Soviet Russia, text read you!
    • View Profile
    • Github
Re: CD-Key Exception
« Reply #20 on: February 17, 2010, 01:23:07 pm »
Odd, you're right. I don't know why I was getting password errors.. probably running unfixed code while my fiance was yelling at me to come to bed. Ahh, late night programming.

So now all I have to do is change the namespace of every single class, fix the 300 bugs that makes, and then 2.1.3 should be ready to ship.
I'd personally do as Joe suggests

You might be right about that, Joe.


Offline Lance

  • Full Member
  • ***
  • Posts: 129
    • View Profile
Re: CD-Key Exception
« Reply #21 on: February 17, 2010, 10:31:22 pm »
Odd, you're right. I don't know why I was getting password errors.. probably running unfixed code while my fiance was yelling at me to come to bed. Ahh, late night programming.

So now all I have to do is change the namespace of every single class, fix the 300 bugs that makes, and then 2.1.3 should be ready to ship.

Sorry to be the one to add three more things to the list  :P, though these are just minor graphical problems.

You may already be aware of one or two of these issues, but just in case you are not I am listing them here.

No icons are showing in the Channel List. This is from the stack trace:
Code: [Select]
Loading Alpha
Activating plugin: Simple event processor
Activating plugin: Commands
Activating plugin: Swing Gui
Exception in Metacity for theme "Nodoka": Variable "mini_icon_width" not defined
Activating plugin: Channel list plugin
Activating plugin: Battle.net Login Plugin
Activating plugin: _Default
Error: client icon not found:
Error: client icon not found:
Error: client icon not found:
Error: client icon not found:
Error: client icon not found:
Error: client icon not found:

Also, when I type the text into the message box for a loaded bot, I cannot see what I am typing because the text is the same color as the background. Highlighting the text is the only way to see what is in the box at the moment.

Last, the title bars for individual bots are not displaying properly, and the product icon seems to have the wrong size. To see examples of this, please refer to my previous screenshots.

Running FC11 by the way.

Thanks :)
Quote from: Joe
[23:55:31] [william@enterprise ~/Documents/Programming/javaop2]$ svn commit -m 'Tried to fix StayConnected. Again.'
Committed revision 63.
StayConnected strikes back!