ospap - Alpha1

[iago]

Ah, ok.  That would be useful in a production-type system, but this is "Alpha" and I tell people I'm going to be wiping it when I need to, so it's not such a big deal

[Sidoh]

Ah, ok.  That would be useful in a production-type system, but this is "Alpha" and I tell people I'm going to be wiping it when I need to, so it's not such a big deal

hehe. 

[iago]

Ok, I did some adding.  I added skinnability, but I suck at design so I just made a boring skin modelled after vL's old forum. 

To-do:
- Fix require_authorization
- Fix require_registration
- Add more comments to default skin
- Extra information in the categories table (owner, private)

http://www.javaop.com/~iago/ospap/index.php
http://www.javaop.com/~iago/ospap.tgz

Let me know what you think!  And if somebody is feeling energetic, make me a skin.  Or even design the pages in static html, and I'll convert them to PHP, that's fine too. 

[Sidoh]

Very, very nice work iago.

[iago]

Question1: Do you think users should be able to choose their own skins that they view?
I'm thinking no, because the person running the album might want it to have a particular look and feel, depending on what he's doing with it. 

Question2: Should users be able to choose skins for each of their categories?
I'm thinking yes, because some categories might be special (Christmas one, for example).  But I'm also thinking no, because the skin changing from page-to-page might be a little annoying to users. 

[Blaze]

Question1: I agree.
Question2: Maybe a user preference to not show the theme?

[Sidoh]

#1 - No.

#2 - No.

[iago]

#1 - No.

#2 - No.

I like those answers best, because that's how it is now and I don't have to implement anything new

[Mythix]

It's not about you, its the "consumer"

yes to both.

[Sidoh]

It's not about you, its the "consumer"

yes to both.

I was actually thinking in the mindset of the type of program it is, not just the amount of work iago would have to put in to implement these features.

I'm thinking no, because the person running the album might want it to have a particular look and feel, depending on what he's doing with it. 

No.
Justification:  What iago said.  The user may have a look/feel that they want to go along with that album, and allowing users to automatically overwrite that (often without their knowledge -- they probably won't know that the set template is different then the one they've specified they want globally) doesn't really seem sensical to me.

Question2: Should users be able to choose skins for each of their categories?
I'm thinking yes, because some categories might be special (Christmas one, for example).  But I'm also thinking no, because the skin changing from page-to-page might be a little annoying to users. 

No.
Justification:  What iago said.  I don't know about you, but I really don't like having a layout change on me that often.  Especially when navigation and things of this manner are changed (which they often are from template to template).

[zorm]

A couple of suggestions instead of doing things like

function display_footer()
{

print("<HR>\n");

print("Written by <A HREF=\"mailto:iago@valhallalegends.com\">Ron Bowes</A>, 2005.  Comments welcome!\n");

print("</BODY>\n");

print("</HTML>\n");
}

in the skins try something like

function display_footer()
{

$footer = <<< FOOTER
<HR>
Written by <A HREF="mailto:iago@valhallalegends.com">Ron Bowes</A>, 2005.  Comments welcome!
</BODY>
</HTML>

FOOTER;

print($footer);
}

Much friendlier when you want to go and change it.

Also when viewing images you should use Previous/Next vs the image's title because it makes it nicer and prevents someone from making a short title and forcing me to move my mouse.

[Sidoh]

I'd recommend making a file 'header.php' or something to that affect.

[iago]

A couple of suggestions instead of doing things like

function display_footer()
{

print("<HR>\n");

print("Written by <A HREF=\"mailto:iago@valhallalegends.com\">Ron Bowes</A>, 2005.  Comments welcome!\n");

print("</BODY>\n");

print("</HTML>\n");
}

in the skins try something like

function display_footer()
{

$footer = <<< FOOTER
<HR>
Written by <A HREF="mailto:iago@valhallalegends.com">Ron Bowes</A>, 2005.  Comments welcome!
</BODY>
</HTML>

FOOTER;

print($footer);
}

Much friendlier when you want to go and change it.

I personally like print's better, in every language I've used I've stuck with that, but since I hope that Templates will be used by others, I'll change it. 

Also when viewing images you should use Previous/Next vs the image's title because it makes it nicer and prevents someone from making a short title and forcing me to move my mouse.

Good point.  Why don't you hover your mouse over the arrow ("-->"), since that doesn't move?  I'll fix that up anyway

Thanks!

[Blaze]

I think your picture.php is broken right now, none of the pictures are working.

[iago]

hmm, they work for me!

Can you view the picture alone (right click -> view image), then view source.  Is there some kind of english text being stuck in there?