[C/C++] Joe vs Ergot: Code wars!

[Ergot]

It does. That's why I use scanf().

[AntiVirus]

Code Select Expand

// C++ binary->decimal converter
// Author: Joe[e2]

#include <iostream.h>
#include <stdio.h>
using namespace std;

int main() {
  string binary;
  int accum = 0;
  int add = 255;

  printf("Enter binary digits:\n");
  cin >> binary;
  add = 128;
  for(int i = 0; i < 8; i++) {
    if(binary.substr(i, 1) == "1") { accum = accum + add; }
    add = add / 2;
  }

  cout << binary << "b = " << accum << "\n";
  return 0;
}

That makes a horrible asumption that the string's length is always 8, but it also handles the error of it being more than 8, by only using the first 8. I don't know how C++ would handle me trying, say, binary[999] when it only goes up to 7. Asuming it will return an 0x00 (which isn't an 0x31), it will test as a "0".

EDIT -

joe@JoeMomma:~/dev/cpp/helloworld $ ./binconv
Enter binary digits:
10
Aborted

I didn't code that anywhere. Runtime error?

I compiled your code with MSV C++ and I got these errors:

--------------------Configuration: Binary converter - Win32 Debug--------------------
Compiling...
Binary converter.cpp
u:\binary converter.cpp(6) : error C2871: 'std' : does not exist or is not a namespace
u:\binary converter.cpp(9) : error C2065: 'string' : undeclared identifier
u:\binary converter.cpp(9) : error C2146: syntax error : missing ';' before identifier 'binary'
u:\binary converter.cpp(9) : error C2065: 'binary' : undeclared identifier
u:\binary converter.cpp(17) : error C2228: left of '.substr' must have class/struct/union type
Error executing cl.exe.

Binary converter.obj - 5 error(s), 0 warning(s)

So, then I took the ".h" off the end of the #include <iostream.h> making it read #include <iostream> which brought me down to three errors:

--------------------Configuration: Binary converter - Win32 Debug--------------------
Compiling...
Binary converter.cpp
u:\binary converter.cpp(14) : error C2679: binary '>>' : no operator defined which takes a right-hand operand of type 'class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >' (or there is no acceptable conversion)
u:\binary converter.cpp(17) : error C2676: binary '==' : 'class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >' does not define this operator or a conversion to a type acceptable to the predefined operator
u:\binary converter.cpp(21) : error C2679: binary '<<' : no operator defined which takes a right-hand operand of type 'class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >' (or there is no acceptable conversion)
Error executing cl.exe.

Binary converter.obj - 3 error(s), 0 warning(s)

And I don't know what to do from there. Right now.  I will look at if later if someone else doesn't figure it out first.

I hope that helps a little..

[Ergot]

#include <stdio.h>
using namespace std;

int main() {
  string binary;
  int accum = 0;
  int add = 255;

  printf("Enter binary digits:\n");
  scanf("%s", binary); //might need a space in front of that % sign...
  add = 128;
  for(int i = 0; i < 8; i++) {
    if(binary.substr(i, 1) = "1") { accum = accum + add; }
    add = add / 2;
  }

  printf("%sb = %d\n",binary, accum);
  return 0;
}

just off the top of my head... to get rid of iostream all together... I nevered used it... doesn't seem necessary for now...

[Joe]

Brandon, might want to look into a Win32 port of g++.

EDIT -
http://www.mingw.org/

[AntiVirus]

Brandon, might want to look into a Win32 port of g++.

EDIT -
http://www.mingw.org/

Okay, but I don't know what that is. :(

Will you explain a little?  I went to the site, and I didn't see anything about what you said.  I will keep looking, but will you still elaborate a little?

[Edit]
I read some more, and I am not sure if I found anything of use..  Maybe, I just don't understand what I am reading. (*sigh*)

[Ergot]

Me thinks it's a C++ compiler for Windows.

[AntiVirus]

Okay, that would make since.  But, why would he tell me to look at it?  Is MSV C++ bad? 

[Ergot]

He would think so if it doesn't compile his code.

[drka]

if mingw cant compile managed code, then it sucks

[MyndFyre]

He would think so if it doesn't compile his code.

If he coded correctly (like using #include <stdio> or #include <iostream> as opposed to #include <stdio.h> and #include <iostream.h>), and maybe only used one I/O header, he might be better-off.  :P

[Ergot]

I use #include <stdio.h> :( I should fix that ;O !

[Joe]

Heh, use the GNU C++ compiler. If it doesn't work with GNU, its broken!

[rabbit]

Or you're lazy.

[Joe]

GNU is the best. GNU rocks. <3 GNU. If I were lazy, this topic wouldn't exist. What C++ compiler should I aim to have this work with? M$VC? Right, well, I'll go pay a thousand dollars for software I use as a hobby. Wait.. The GNU C++ compiler is free. Bingo!

[AntiVirus]

Well, I already have the software.. so I am just going to stick with MsV C++ ;)